Skip to content

Fix library-like compiler path configs#2744

Draft
toinehartman wants to merge 1 commit intomainfrom
fix/2743-library-like-path-configs
Draft

Fix library-like compiler path configs#2744
toinehartman wants to merge 1 commit intomainfrom
fix/2743-library-like-path-configs

Conversation

@toinehartman
Copy link
Copy Markdown
Member

Fixes #2743.

@toinehartman toinehartman self-assigned this Apr 2, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (827298e) to head (41868a7).

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2744   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6721    6729    +8     
=======================================
  Files          794     794           
  Lines        65912   65917    +5     
  Branches      9888    9891    +3     
=======================================
+ Hits         30824   30844   +20     
+ Misses       32698   32691    -7     
+ Partials      2390    2382    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix towards the next step (never creating pathconfig for library projects anymore)

}

@Test
public void stdConfig() throws IOException, URISyntaxException {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toinehartman this is the test you wanted to remove right?

Copy link
Copy Markdown
Member Author

@toinehartman toinehartman Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussion, I was thinking of nuking this PR altogether, instead fixing this where library modules are opened (in LSP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path config computation is incorrect for std

2 participants