Fix start&top implementation in typechecker#2551
Draft
DavyLandman wants to merge 2 commits intomainfrom
Draft
Conversation
This reverts commit 570bd8e.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6721 6713 -8
=======================================
Files 794 794
Lines 65912 65912
Branches 9888 9888
=======================================
- Hits 30824 30808 -16
- Misses 32698 32711 +13
- Partials 2390 2393 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
jurgenvinju
reviewed
Apr 1, 2026
Member
jurgenvinju
left a comment
jurgenvinju
left a comment
There was a problem hiding this comment.
Looks good. Needs an integration test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work in #2499 (that was merged to main a bit too soon) to fix #2496