made required location of shield files for local builds explicit in readme#143
Open
made required location of shield files for local builds explicit in readme#143
Conversation
Owner
|
The problem with that approach is that changes to zmk get wiped out if you run |
Author
|
I was not aware of that, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it quite unintuitive that files for custom shields need to go into
zmk/app/boards/shieldsinstead ofboards/shieldsso I made it explicit in the readme.When the files are in
boards/shieldsone get error messages, that the shield files are used, but at the same time, that the shield is invalid.Thank you for the amazing repo and the local toolchain setup 💜