Skip to content

Doco updates and questions#17

Open
lazzarello wants to merge 9 commits intoupmc-enterprises:masterfrom
lazzarello:doco
Open

Doco updates and questions#17
lazzarello wants to merge 9 commits intoupmc-enterprises:masterfrom
lazzarello:doco

Conversation

@lazzarello
Copy link
Copy Markdown

Getting set up with your awesome project. Shuffles some things around in the docs, asked some questions. Open to answers as review.

Copy link
Copy Markdown
Contributor

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a couple things to clean up in the docs.

Comment thread README.MD Outdated
* To push your image to docker hub, set $PREFIX to your account name, then `make push`

## Get Started
1. Create auth tokens file (how?)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tokens can be whatever length or format you would like, I typically just generate a random string .

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks for confirming. I'll update with a "generate a SHA-1" one-liner.

Comment thread README.MD Outdated

## Building

* Install Go
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to golang.org?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linked to the getting started/install stuff

@lazzarello
Copy link
Copy Markdown
Author

I added an example token generation step, then deployed the secret and the rc spec to my k8s cluster. looking good so far. moving onto the services.

@stevesloka
Copy link
Copy Markdown
Contributor

Awesome! Thanks so much for this! Would you mind rebasing + squashing down before merging?

@lazzarello
Copy link
Copy Markdown
Author

I did rebase. I think you can alter the commits if you like. I commit a lot. It's a habit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants