Skip to content

Reclassifying ERRORS in data generation - see issue #238 #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sven-oly wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reclassifying ERRORS in data generation - see issue #238 #525

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb2cbab
Reclassifying ERRORS in data generation - see issue #238
Sep 24, 2024
bb879c8
Change exception type
sven-oly Sep 6, 2025
66bd66b
Fix type of exceptions
sven-oly Oct 9, 2025
20a940e
merging
sven-oly Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testgen/generators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def readFile(self, filename, version="", filetype="txt"):
with open(path, "r", encoding="utf-8") as testdata:
return json.load(testdata) if filetype == "json" else testdata.read()
except BaseException as err:
Comment thread
sven-oly marked this conversation as resolved.
Outdated
logging.warning("** READ: Error = %s", err)
logging.warning("** readFile: %s", err)
return None

def computeMaxDigitsForCount(self, count):
Expand Down
2 changes: 1 addition & 1 deletion testgen/generators/datetime_fmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def process_test_data(self):
]

if self.icu_version not in icu_nvm_versions:
logging.error('Generating datetime data not configured for icu version %s', self.icu_version)
logging.warning('Generating datetime data not configured for icu version %s', self.icu_version)
return False

# Set up Node version and call the generator
Expand Down
2 changes: 1 addition & 1 deletion testgen/generators/list_fmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def process_test_data(self):
]

if self.icu_version not in icu_nvm_versions:
logging.error('Generating list_fmt data not configured for icu version %s', self.icu_version)
logging.warning('Generating list_fmt data not configured for icu version %s', self.icu_version)
return False

# Set up Node version and call the generator
Expand Down
2 changes: 1 addition & 1 deletion testgen/generators/relativedatetime_fmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def process_test_data(self):
]

if self.icu_version not in icu_nvm_versions:
logging.error('Generating relative date/time data not configured for icu version %s', self.icu_version)
logging.warning('Generating relative date/time data not configured for icu version %s', self.icu_version)
return False

# Set up Node version and call the generator
Expand Down
Loading