Adds embedded figure binaries in json upload#2016
Open
iturgeon wants to merge 2 commits intoucfopen:dev/31-taconitefrom
Open
Adds embedded figure binaries in json upload#2016iturgeon wants to merge 2 commits intoucfopen:dev/31-taconitefrom
iturgeon wants to merge 2 commits intoucfopen:dev/31-taconitefrom
Conversation
Adds initial support for uploading obojobo module .json files that can include image binary data in the json. Previously it was not possible to import a json file with the images referenced in it's chunks due to them referencing ID's in specific obojobo instance they were being created on. This change allows figure chunks to support a new content property named 'imageBinary' that contains base64 encoded image data when uploading via the dashboard in .json formatted modules. This also provides a script that can be run against an existing .json module on your local files and populate imageBinary for you. It will will attempt to locate images by their content.filename in the directory (or sub directory) of the .json module you provide See embedFigureBinary.js for usage. This change does not support embedding image binaries in xml formatted modules and I have not tested support for uploading .json in the editor. (cherry picked from commit 9cc4a4f7401709417807b5543effc031900ec315)
Member
Author
|
The tests don't currently pass & I'm not sure exactly which branch to target, you'll have to let me know @FrenjaminBanklin |
Member
Author
|
To upload a json file with curl, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial support for uploading obojobo module .json files
that can include image binary data in the json. Previously it
was not possible to import a json file with the images referenced
in it's chunks due to them referencing ID's in specific obojobo
instance they were being created on.
This change allows figure chunks to support a new content property
named 'imageBinary' that contains base64 encoded image data when
uploading via the dashboard in .json formatted modules.
This also provides a script that can be run against an existing
.json module on your local files and populate imageBinary for you.
It will will attempt to locate images by their content.filename
in the directory (or sub directory) of the .json module you provide
See embedFigureBinary.js for usage.
This change does not support embedding image binaries in xml formatted
modules and I have not tested support for uploading .json in the editor.