Relocate unit tests for obojobo-document-engine and obojobo-express packages#1984
Open
FrenjaminBanklin wants to merge 36 commits intoucfopen:dev/31-taconitefrom
Open
Relocate unit tests for obojobo-document-engine and obojobo-express packages#1984FrenjaminBanklin wants to merge 36 commits intoucfopen:dev/31-taconitefrom
FrenjaminBanklin wants to merge 36 commits intoucfopen:dev/31-taconitefrom
Conversation
…ent to the files they are testing and updated import/require paths as necessary. Fixed filenames where applicable. Renamed extensions for all React components from .js to .jsx.
…o be adjacent to the files they are testing. Made corrections to require/import paths as necessary. Fixed filenames where necessary. Changed extensions for remaining React component files from '.js' to '.jsx' for consistency.
…ort paths where applicable.
jpeterson976
previously approved these changes
Mar 8, 2022
Contributor
jpeterson976
left a comment
jpeterson976
left a comment
There was a problem hiding this comment.
Tests still pass and coverage is still at 100%. LGTM
Contributor
|
Everything LGTM as well, and the tests are all passing. However, there is one conflict on |
FrenjaminBanklin
changed the base branch from
dev/28-jadeite
to
dev/29-sodalite
FrenjaminBanklin
dismissed
jpeterson976’s stale review
The base branch was changed.
…flicts. Fixed stylelint errors.
FrenjaminBanklin
changed the base branch from
dev/29-sodalite
to
dev/30-howlite
…sanitation to remove regex reserved characters. Corrected post-merge unit tests to remove tests that are no longer relevant.
FrenjaminBanklin
changed the base branch from
dev/30-howlite
to
dev/31-taconite
…pattern are replaced with new UUIDs. References to the old node IDs in button actions etc. are also replaced with the corresponding new IDs.
…rt Node 18. Updated Node version requirements in relevant package.json files, fixed new undefined error message in tests.
Dev/31 - Taconite
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Updates Node to version 18.
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…word-wrap-1.2.4 Bump word-wrap from 1.2.3 to 1.2.4
…semver-5.7.2 Bump semver from 5.7.1 to 5.7.2
…ase-two Implemented Phase 2 for Obo Stats
…d-nodes-on-copy Reset element IDs in copied modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1951.
Moves unit test files for the
obojobo-document-engineandobojobo-expresspackages from a dedicated__tests__directory to be adjacent to the files they're actually testing, as in theobojobo-repositoryand allobonodepackages.Leaving
obojobo-document-json-parserandobojobo-document-xml-parserpackages for now since the tests aren't really 1:1 with the files they're testing anyway. There are currently no tests in theobojobo-module-selectorpackage to move.