When creating the command struct, set ShellBang to runtime.GOOS=plan9#38
Open
rminnich wants to merge 2 commits intou-root:mainfrom
Open
When creating the command struct, set ShellBang to runtime.GOOS=plan9#38rminnich wants to merge 2 commits intou-root:mainfrom
rminnich wants to merge 2 commits intou-root:mainfrom
Conversation
Member
Author
|
yess, I know, should be bang, not bag :-) |
Member
Author
|
This does not work, still not totally sure why. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 75.34% 75.34%
=======================================
Files 24 24
Lines 1521 1521
=======================================
Hits 1146 1146
Misses 279 279
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
rminnich
force-pushed
the
plan9-default-shellbag
branch
from
517bc24 to
2ac268a
Compare
Member
|
Did it work eventually @rminnich ? I see a later force push, but no further comment; should we set this to draft for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plan 9 has no symlinks, so create proper default behavior.
It's not clear what we should default to for Windows.