add option to specify go -compiler, e.g. tinygo see u-root/gobusybox#121#34
Open
archie2x wants to merge 1 commit intou-root:mainfrom
Open
add option to specify go -compiler, e.g. tinygo see u-root/gobusybox#121#34archie2x wants to merge 1 commit intou-root:mainfrom
archie2x wants to merge 1 commit intou-root:mainfrom
Conversation
Member
|
oops, requires DCO (i.e. |
Member
|
Huh, apparently something broke within I assume that is an internal, unstable API? 😬 Edit: |
Author
|
I can take a look after I get a cup of coffee today... |
orangecms
added a commit
to platform-system-interface/mkuimage
that referenced
this pull request
Apr 13, 2026
The move of gobusybox to Go 1.25 would force mkuimage to use it, too. This upgrade enables the open PR for adding the `-compiler` option: u-root#34 Signed-off-by: Daniel Maslowski <info@orangecms.org>
orangecms
added a commit
to platform-system-interface/mkuimage
that referenced
this pull request
Apr 13, 2026
The move of gobusybox to Go 1.25 forces mkuimage to use it, too. This upgrade enables the open PR for adding the `-compiler` option: u-root#34 Signed-off-by: Daniel Maslowski <info@orangecms.org>
orangecms
added a commit
to platform-system-interface/mkuimage
that referenced
this pull request
Apr 13, 2026
The move of gobusybox to Go 1.25 forces mkuimage to use it, too. This upgrade enables the open PR for adding the `-compiler` option: u-root#34 Signed-off-by: Daniel Maslowski <info@orangecms.org>
orangecms
added a commit
to platform-system-interface/mkuimage
that referenced
this pull request
Apr 13, 2026
The move of gobusybox to Go 1.25 forces mkuimage to use it, too. This upgrade enables the open PR for adding the `-compiler` option: u-root#34 To get to 1.25, this also does: * cross-compile.sh: drop windows/arm This has been removed upstream, being broken since Go 1.18. golang/go#71671 * CI: bump to Go 1.25 and 1.26 actions for lint workflow * migrate golangci config This is the result of running `golangci-lint migrate` using v2.11.4. <https://golangci-lint.run/docs/product/migration-guide/> Note: exclusions have been reworked, and the migration dropped them. <golangci/golangci-lint#5298> Signed-off-by: Daniel Maslowski <info@orangecms.org>
Member
I took care of the version bumps, tried your change locally, and it works! :) |
orangecms
added a commit
that referenced
this pull request
Apr 13, 2026
The move of gobusybox to Go 1.25 forces mkuimage to use it, too. This upgrade enables the open PR for adding the `-compiler` option: #34 To get to 1.25, this also does: * cross-compile.sh: drop windows/arm This has been removed upstream, being broken since Go 1.18. golang/go#71671 * CI: bump to Go 1.25 and 1.26 actions for lint workflow * migrate golangci config This is the result of running `golangci-lint migrate` using v2.11.4. <https://golangci-lint.run/docs/product/migration-guide/> Note: exclusions have been reworked, and the migration dropped them. <golangci/golangci-lint#5298> Signed-off-by: Daniel Maslowski <info@orangecms.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 75.34% 75.44% +0.09%
==========================================
Files 24 24
Lines 1521 1527 +6
==========================================
+ Hits 1146 1152 +6
Misses 279 279
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
just one trivial lint error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propogates -compiler option from u-root/gobusybox#121 to mkuimage