Skip to content

Don't run misc job under JDK 17#7714

Merged
mernst merged 2 commits into
typetools:masterfrom
mernst:no-misc-17
May 13, 2026
Merged

Don't run misc job under JDK 17#7714
mernst merged 2 commits into
typetools:masterfrom
mernst:no-misc-17

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 11, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f792c9bb-45d9-40c4-9283-f34543bc70c0

📥 Commits

Reviewing files that changed from the base of the PR and between 26c033b and 1b3f925.

📒 Files selected for processing (1)
  • .circleci/config.yml
💤 Files with no reviewable changes (1)
  • .circleci/config.yml

📝 Walkthrough

Walkthrough

This PR removes Java 17 from the project's CI/CD testing infrastructure by deleting the misc_jdk17 job definition from Azure Pipelines (.azure/azure-pipelines.yml and .azure/jobs.m4), CircleCI (.circleci/config.yml), and GitHub Workflows (.github/workflows/ci.yml). It also adds a comment to checker/bin-devel/test-misc.sh noting the script cannot be run under Java 17. The CircleCI workflows section may still reference the removed misc_jdk17 job.

Possibly related PRs

  • typetools/checker-framework#7324: Both PRs modify the CI configuration for misc_jdk17 (this PR removes the job; #7324 changes checkout/history behavior and comments related to misc_jdk17).
  • typetools/checker-framework#7665: Both PRs touch CircleCI workflow dependency wiring related to version-specific misc jobs including the JDK17 misc job.
  • typetools/checker-framework#7670: Both PRs touch the misc JDK job configuration for JDK17; #7670 changes how ORG_GRADLE_PROJECT_jdkTestVersion is set while this PR removes the JDK17 job.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

smillst
smillst previously approved these changes May 13, 2026
@smillst smillst assigned mernst and unassigned smillst May 13, 2026
@mernst mernst merged commit a2ede71 into typetools:master May 13, 2026
34 checks passed
@mernst mernst deleted the no-misc-17 branch May 13, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants