StorehausSourceTap#213
Conversation
There was a problem hiding this comment.
I think ks could be weakened to Iterable[K] which can be lazy and not something that can anwer .contains calls.
There was a problem hiding this comment.
actually, I think we are going to want a Spool[K] here, or even () => Spool[K] or the equivalent.
In fact, on the source side, maybe what we want is a Spool source, and a way to convert a
(Spool[K], ReadableStore[K, V]) => Spool[(K, Option[V])]
Then we can use this for even more cases.
That said, the sink side really looks like a Writable[K, V] I think.
There was a problem hiding this comment.
There was a problem hiding this comment.
@AndreasPetter I had a brief chat about this with @johnynek sometime back.
Config parameters can be passed via the JobConf I think. Here is an example of how cascading-jdbc does it for JDBCTap:
https://github.com/Cascading/cascading-jdbc/blob/2.5/cascading-jdbc-core/src/main/java/cascading/jdbc/db/DBConfiguration.java
For store creation on the mappers, it looks like we'll need to pass a StoreProvider of some kind which knows how to generate a ReadableStore.
|
@rubanm as i would be a thankful user of a Summingbird-batching Storehaus tap (i will need a SinkTap pretty soon), do you already have plans for a final pull request? If i can be of any help with the SinkTap i would be happy to join you working on it. |
|
@AndreasPetter Sorry haven't been able to work on this for a while. You are more than welcome to start on the SinkTap and pull in any code from this PR if that's useful. I can help, and we have @johnynek of course :) Thanks. |
|
👍 love it |
Addresses #208
This is an untested first draft that adds some basic cascading wiring.
Sending it out early for any design feedback as well as any missing big picture items.
I am thinking of having the source tap completely done before moving to the sink tap.