Skip to content

Filter away statics we don't want to see

4894ec9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Filter away statics we don't want to see #36

Filter away statics we don't want to see
4894ec9
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 22, 2025 in 1s

clippy

26 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 26
Note 0
Help 0

Versions

  • rustc 1.88.0 (6b00bc388 2025-06-23)
  • cargo 1.88.0 (873a06493 2025-05-10)
  • clippy 0.1.88 (6b00bc3880 2025-06-23)

Annotations

Check warning on line 121 in cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> cli/src/main.rs:121:9
    |
121 |         print!("{}: ", i);
    |         ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
    |
121 -         print!("{}: ", i);
121 +         print!("{i}: ");
    |

Check warning on line 160 in trace/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/lib.rs:160:42
    |
160 |             kind_text = theme.color_info(format!("({}) ", kind_text)).to_string();
    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
160 -             kind_text = theme.color_info(format!("({}) ", kind_text)).to_string();
160 +             kind_text = theme.color_info(format!("({kind_text}) ")).to_string();
    |

Check warning on line 42 in trace/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> trace/src/lib.rs:42:21
   |
42 |                     write!(f, ":{}", column)?;
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
42 -                     write!(f, ":{}", column)?;
42 +                     write!(f, ":{column}")?;
   |

Check warning on line 40 in trace/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> trace/src/lib.rs:40:17
   |
40 |                 write!(f, ":{}", line)?;
   |                 ^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
40 -                 write!(f, ":{}", line)?;
40 +                 write!(f, ":{line}")?;
   |

Check warning on line 38 in trace/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
  --> trace/src/lib.rs:38:13
   |
38 |             write!(f, "{}", file)?;
   |             ^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
   |
38 -             write!(f, "{}", file)?;
38 +             write!(f, "{file}")?;
   |

Check warning on line 785 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> trace/src/variables/mod.rs:782:17
    |
782 | /                 match piece.location {
783 | |                     gimli::Location::Address { address } => return Some(address),
784 | |                     _ => {}
785 | |                 }
    | |_________________^ help: try: `if let gimli::Location::Address { address } = piece.location { return Some(address) }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default

Check warning on line 772 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/variables/mod.rs:772:68
    |
772 |             VariableDataError::UnimplementedLocationEvaluationStep(format!("{:?}", step)),
    |                                                                    ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
772 -             VariableDataError::UnimplementedLocationEvaluationStep(format!("{:?}", step)),
772 +             VariableDataError::UnimplementedLocationEvaluationStep(format!("{step:?}")),
    |

Check warning on line 755 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> trace/src/variables/mod.rs:755:64
    |
755 |                 let piece_data = get_piece_data(device_memory, &piece, variable_size_bytes)?;
    |                                                                ^^^^^^ help: change this to: `piece`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 584 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/variables/mod.rs:584:9
    |
584 |         log::trace!("Location evaluation result: {:?}", result);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
584 -         log::trace!("Location evaluation result: {:?}", result);
584 +         log::trace!("Location evaluation result: {result:?}");
    |

Check warning on line 506 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
   --> trace/src/variables/mod.rs:506:5
    |
506 | /// This may be a None if the variable has no location attribute.
    |     ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
506 | ///   This may be a None if the variable has no location attribute.
    |     ++

Check warning on line 209 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `as_*` usually take `self` by reference or `self` by mutable reference

warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
   --> trace/src/variables/mod.rs:209:23
    |
209 |     fn as_trace_error(self) -> TraceError {
    |                       ^^^^
    |
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
    = note: `#[warn(clippy::wrong_self_convention)]` on by default

Check warning on line 197 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/variables/mod.rs:197:31
    |
197 |                 gotten_value: format!("{:X?}", value),
    |                               ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
197 -                 gotten_value: format!("{:X?}", value),
197 +                 gotten_value: format!("{value:X?}"),
    |

Check warning on line 144 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/variables/mod.rs:144:31
    |
144 |                 gotten_value: format!("{:X?}", value),
    |                               ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
144 -                 gotten_value: format!("{:X?}", value),
144 +                 gotten_value: format!("{value:X?}"),
    |

Check warning on line 75 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> trace/src/variables/mod.rs:75:17
   |
75 |                 return Ok("subroutine".into());
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
   |
75 -                 return Ok("subroutine".into());
75 +                 Ok("subroutine".into())
   |

Check warning on line 71 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> trace/src/variables/mod.rs:71:17
   |
71 |                 return Ok("array".into());
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
71 -                 return Ok("array".into());
71 +                 Ok("array".into())
   |

Check warning on line 202 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

binary comparison to literal `Option::None`

warning: binary comparison to literal `Option::None`
   --> trace/src/platform/mod.rs:202:16
    |
202 |             if var.address == None || var.address == Some(0) {
    |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `var.address.is_none()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
    = note: `#[warn(clippy::partialeq_to_none)]` on by default

Check warning on line 175 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> trace/src/platform/mod.rs:175:50
    |
175 |         if let Some(symbol) = elf.symbol_by_name(&linkage_name) {
    |                                                  ^^^^^^^^^^^^^ help: change this to: `linkage_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 51 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> trace/src/platform/mod.rs:51:5
   |
51 | /// This must be the exact same elf file as the one the device was running. Even a recompilation of the exact same code can change the de...
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
51 | ///   This must be the exact same elf file as the one the device was running. Even a recompilation of the exact same code can change the debug info.
   |     ++

Check warning on line 49 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> trace/src/platform/mod.rs:49:5
   |
49 | /// The standard set of registers is also required to be present.
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
49 | ///   The standard set of registers is also required to be present.
   |     ++

Check warning on line 48 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> trace/src/platform/mod.rs:48:5
   |
48 | /// then eventually the tracing procedure will find a corrupt frame.
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
48 | ///   then eventually the tracing procedure will find a corrupt frame.
   |     ++

Check warning on line 47 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> trace/src/platform/mod.rs:47:5
   |
47 | /// It is required to have a decent chunk of the stack present. If not all of the stack is present,
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
47 | ///   It is required to have a decent chunk of the stack present. If not all of the stack is present,
   |     ++

Check warning on line 46 in trace/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> trace/src/platform/mod.rs:46:5
   |
46 | /// It is not necessary to include any data that is present in the elf file because that will automatically be added.
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
46 | ///   It is not necessary to include any data that is present in the elf file because that will automatically be added.
   |     ++

Check warning on line 301 in trace/src/platform/cortex_m/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

warning: variables can be used directly in the `format!` string
   --> trace/src/platform/cortex_m/mod.rs:298:62
    |
298 |   ...                   frame_type: FrameType::Corrupted(format!(
    |  ________________________________________________________^
299 | | ...                       "Could not read address {:#10X} from the stack",
300 | | ...                       address
301 | | ...                   )),
    | |_______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default

Check warning on line 254 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`crate` references the macro call's crate

warning: `crate` references the macro call's crate
   --> trace/src/variables/mod.rs:254:17
    |
254 |             Err(crate::variables::GetEntryTreeError::WrongUnit(target_unit)) => {
    |                 ^^^^^ help: to reference the macro definition's crate, use: `$crate`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def

Check warning on line 228 in trace/src/variables/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`crate` references the macro call's crate

warning: `crate` references the macro call's crate
   --> trace/src/variables/mod.rs:228:17
    |
228 |             Err(crate::variables::GetEntryTreeError::WrongUnit(target_unit)) => {
    |                 ^^^^^ help: to reference the macro definition's crate, use: `$crate`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def
    = note: `#[warn(clippy::crate_in_macro_def)]` on by default