message, retry: include error code in retry receipt#956
Open
purpshell wants to merge 2 commits intotulir:mainfrom
Open
message, retry: include error code in retry receipt#956purpshell wants to merge 2 commits intotulir:mainfrom
purpshell wants to merge 2 commits intotulir:mainfrom
Conversation
purpshell
force-pushed
the
fix/error-on-retry-receipts
branch
from
bc9436f to
cfe5fd0
Compare
tulir
reviewed
Oct 5, 2025
| func getRetryReasonFromError(err error) int { | ||
| switch { | ||
| case errors.Is(err, signalerror.ErrBadMAC): | ||
| return RetryReasonSignalErrorBadMac |
Owner
There was a problem hiding this comment.
Reaching this case (and possibly others) requires some changes to libsignal-protocol-go to make it return the real error. Currently it tries all previous states and then hides the original error by returning signalerror.ErrNoValidSessions
Contributor
Author
There was a problem hiding this comment.
Should be resolved after tulir/libsignal-protocol-go#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.