status: Add req.Participants for Status message#800
Open
devlikepro wants to merge 1 commit intotulir:mainfrom
Open
status: Add req.Participants for Status message#800devlikepro wants to merge 1 commit intotulir:mainfrom
devlikepro wants to merge 1 commit intotulir:mainfrom
Conversation
With req.Participants we can send status message to many (>50K) contacts in chunks, using the same message.id
| err = fmt.Errorf("failed to get broadcast list members: %w", err) | ||
| return | ||
| if len(req.Participants) != 0 { | ||
| groupParticipants = req.Participants |
There was a problem hiding this comment.
IMHO it's better to validate/eliminate the participants that violate user privacy settings like blacklist
see getBroadcastListParticipants for reference
Contributor
|
#900 has effects here, what do you think @devlikepro? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there's a problem when you try to send status (stories) message to contacts if you have > 50K contacts.
Web send such big messages in chunks, using the same message.id.
The RP add
req.Participantswe can send status message to many (>50K) contacts in chunks, using the same message.idNote: May be we need to add some assertion about
req.Participantsbeing set and allow it only forstatus@broadcast, because right now it can confuse API a bit. Or may be name it likereq.StatusBroadcast[Receipents|Participants]🤔Let me know how we can improve the changes, I'll do that!