Skip to content

msgsecret: fix poll vote encryption using wrong identity #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalix127 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

msgsecret: fix poll vote encryption using wrong identity #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions msgsecret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ func (cli *Client) EncryptPollVote(ctx context.Context, pollInfo *types.MessageI
if err != nil {
return nil, fmt.Errorf("failed to marshal poll vote protobuf: %w", err)
}
ciphertext, iv, err := cli.encryptMsgSecret(ctx, cli.getOwnID(), pollInfo.Chat, pollInfo.Sender, pollInfo.ID, EncSecretPollVote, plaintext)
ciphertext, iv, err := cli.encryptMsgSecret(ctx, cli.getOwnLID(), pollInfo.Chat, pollInfo.Sender, pollInfo.ID, EncSecretPollVote, plaintext)
if err != nil {
return nil, fmt.Errorf("failed to encrypt poll vote: %w", err)
}
Expand All @@ -347,7 +347,6 @@ func (cli *Client) EncryptComment(ctx context.Context, rootMsgInfo *types.Messag
if err != nil {
return nil, fmt.Errorf("failed to marshal comment protobuf: %w", err)
}
// TODO is hardcoding LID here correct? What about polls?
ciphertext, iv, err := cli.encryptMsgSecret(ctx, cli.getOwnLID(), rootMsgInfo.Chat, rootMsgInfo.Sender, rootMsgInfo.ID, EncSecretComment, plaintext)
if err != nil {
return nil, fmt.Errorf("failed to encrypt comment: %w", err)
Expand Down