msgsecret: fix poll vote encryption using wrong identity #1107
Open
kalix127 wants to merge 1 commit intotulir:mainfrom
Open
msgsecret: fix poll vote encryption using wrong identity #1107kalix127 wants to merge 1 commit intotulir:mainfrom
kalix127 wants to merge 1 commit intotulir:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncryptPollVoteusescli.getOwnID()(Phone Number JID) for key derivation, butSendMessagesends using LID identity. WhatsApp recipients derive the decryption key using the LID, causing a mismatch anddecrypt-fail="hide"on all encrypted poll vote payloads.EncryptCommentandEncryptReactionalready usecli.getOwnLID()correctly. This change alignsEncryptPollVotewith them.
Also removes the TODO on line 350 which questioned whether polls should use LID.
Fixes #1076
See also mautrix/whatsapp#681