Add Korean language support#369
Open
eforgacs wants to merge 1 commit intotsunamods-codes:masterfrom
Open
Conversation
2 tasks
- Add Korean enum value to StringKey.cs - Add 'ko' case to SetLanguageDictionary switch in App.xaml.cs - Add Korean entry to LanguagesMap in SetLanguageViewModel.cs - Add Korean key to English source and all existing language files - Add StringResources.ko.xaml with full Korean UI translation - Add 7H_GameDriver_UI.ko.xml with full Korean game driver translation
eforgacs
force-pushed
the
add-korean-language
branch
from
629d19d to
387bd96
Compare
Member
|
This PR will require someone human and native in Korean to be reviewed that we can trust. We'll let you know until we find someone, so bare with until then. Thanks |
julianxhokaxhiu
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringResources.ko.xamlwith full Korean translations (1262 lines)7H_GameDriver_UI.ko.xmlwith Korean game driver UI strings (369 lines)SetLanguageViewModelTest plan