Skip to content

Add pri as an option#108

Merged
troglobit merged 1 commit intotroglobit:masterfrom
gavinhoward:master
Apr 2, 2026
Merged

Add pri as an option#108
troglobit merged 1 commit intotroglobit:masterfrom
gavinhoward:master

Conversation

@gavinhoward
Copy link
Copy Markdown
Contributor

This makes it so syslogd always prints the priority.

This is also a personal want of mine. I have no idea if it is something that you might want, however.

Copy link
Copy Markdown
Owner

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this as an option would be very useful to more users. However, you need to update the documentation in syslog.conf(5), detailing what the option does and preferably provide a log output example.

Also, the code where you assign start would benefit from a comment describing what it does.

@gavinhoward
Copy link
Copy Markdown
Contributor Author

Making the changes now. Would you like me to amend and force push the changes, or to just commit on top?

@troglobit
Copy link
Copy Markdown
Owner

Making the changes now. Would you like me to amend and force push the changes, or to just commit on top?

Amend and force push, please.

@gavinhoward gavinhoward force-pushed the master branch 2 times, most recently from 14be902 to 6b89340 Compare April 2, 2026 05:22
This makes it so `syslogd` always prints the priority.

Signed-off-by: Gavin D. Howard <gavin@gavinhoward.com>
Copy link
Copy Markdown
Owner

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work on this!

@troglobit
Copy link
Copy Markdown
Owner

aaaand the tests pass. Merging!

@troglobit troglobit merged commit 06df5e9 into troglobit:master Apr 2, 2026
3 of 4 checks passed
@gavinhoward
Copy link
Copy Markdown
Contributor Author

Thank you!

@troglobit
Copy link
Copy Markdown
Owner

Thank you!

No no, thank you for taking the time to contribute to the project! ❤️ 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants