Fix invalid macro_export usage#2320
Merged
Licenser merged 1 commit intotremor-rs:mainfrom May 1, 2023
Merged
Conversation
This fixes build failure with Rust 1.69+. According to [^1], "the only valid argument is `#[macro_export(local_inner_macros)]` or no argument (`#[macro_export]`)". The check for invalid `#[macro_export]` arguments was added in rust-lang/rust#107911 and first released in Rust 1.69.0. [^1]: https://github.com/rust-lang/rust/blob/1.69.0/compiler/rustc_lint_defs/src/builtin.rs#L4129 Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
=======================================
Coverage 91.11% 91.12%
=======================================
Files 275 275
Lines 58093 58093
=======================================
+ Hits 52934 52937 +3
+ Misses 5159 5156 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This fixes build failure with Rust 1.69+. According to 1, "the only valid argument is
#[macro_export(local_inner_macros)]or no argument (#[macro_export])".The check for invalid
#[macro_export]arguments was added in rust-lang/rust#107911 and first released in Rust 1.69.0.Related
Checklist
(Please let me know if this needs to be documented in CHANGELOG.)
rust1.69; use brewed deps Homebrew/homebrew-core#129863)Performance
Not applicable.
Footnotes
https://github.com/rust-lang/rust/blob/1.69.0/compiler/rustc_lint_defs/src/builtin.rs#L4129 ↩