Merged
Conversation
Contributor
joshk
commented
Nov 27, 2015
joshk
commented
- remove Pusher gem and notifier as travis-live takes care of these notifications now
- improve the handling of errors with the GitHub commit status notifier
- switch to the official v3 api for GitHub
- use the GH gem and not the GitHub repo
- improve some logging for the email notifier, as well as the general Sidekiq job notifier
- also listen to a general notifications queue instead of individual notifier queues
also remove new_relic, hasn’t been used in years.
if we get a 401 error (token auth error), log a line and move on. if we get a 403 error (rate limit exceeded), only raise an error if in production. if we get a 404 error (repo not found), log a line and move on as this is most likely an auth error.
we have travis-live for that now
Contributor
Author
|
this is also related to travis-ci/travis-hub#59 |
rkh
added a commit
that referenced
this pull request
Nov 27, 2015
Improve some things and stuff and bits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.