Conversation
R.A.I.N. Lab demo: Watch AI fight my own research paper - James (Lead Scientist) defends Christopher Woodyard's paper - Elena (Quantum Information Theorist) attacks with formal critique - Uses MiniMax M2.7 via Ollama - ~80 second runtime for live demos
|
Thanks for contributing to R.A.I.N.. For faster review, please ensure:
See |
PR intake checks found warnings (non-blocking)Fast safe checks found advisory issues. CI lint/test/build gates still enforce merge quality.
Action items:
Run logs: https://github.com/topherchris420/james_library/actions/runs/24611469499 Detected blocking line issues (sample):
Detected advisory line issues (sample):
|
| @@ -0,0 +1,54 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
🟡 Script has shebang but no execute permission (mode 644)
The file is committed with mode 100644 (not executable), but has #!/bin/bash on line 1. Running ./scripts/hackathon-demo.sh will fail with "Permission denied". Users must use bash scripts/hackathon-demo.sh instead, which defeats the purpose of the shebang.
Prompt for agents
The file scripts/hackathon-demo.sh was committed as 100644 (not executable). Since it has a #!/bin/bash shebang and is intended to be run directly, it should be committed with the executable bit set. Fix with: git update-index --chmod=+x scripts/hackathon-demo.sh and recommit.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32c1fddad8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "" | ||
|
|
||
| echo "Checking Ollama connection..." | ||
| curl -s -o /dev/null -w "Status: %{http_code}\n" "$OLLAMA_HOST/api/tags" || { |
There was a problem hiding this comment.
Fail fast on HTTP errors in Ollama connectivity check
The connectivity gate only checks curl transport failure via ||, but this invocation does not fail on HTTP error status codes, so 404/500 responses still pass and the script proceeds as if Ollama were healthy. In environments where the daemon is up but unhealthy (or the endpoint is proxied/misconfigured), this causes the demo flow to continue into misleading downstream failures instead of stopping at startup.
Useful? React with 👍 / 👎.
| echo "--- JAMES (Lead Scientist - DEFENDS paper) ---" | ||
| RESPONSE=$(curl -s -X POST "$OLLAMA_HOST/api/generate" \ | ||
| -d "{\"model\": \"$MODEL\", \"prompt\": \"You are James, Lead Scientist at Vers3Dynamics R.A.I.N. Lab. DEFEND the paper '$PAPER_TITLE' by $AUTHOR. The core claim: physical reality consists of a discrete state space updated by 5 fundamental geometric rules from which relativistic quantum fields and spacetime emerge. Make a strong case citing: (1) emergence of Dirac equation from chirality propagation on a 5-edge lattice, (2) testable predictions: gamma-ray burst dispersion bounds, 450 qubit decoherence threshold, (3) falsifiability. Be confident, specific, punchy. Under 150 words.\", \"stream\": false}") | ||
| echo "$RESPONSE" | python3 -c "import sys,json; print(json.load(sys.stdin).get('response','ERROR'))" |
There was a problem hiding this comment.
Exit non-zero when /api/generate returns an error payload
This parser treats missing response as a printable fallback ("ERROR") and still exits successfully, so when Ollama returns an error object (for example model-not-found), run_james reports success and all mode continues. That masks failed generations in automation/demo runs and makes it harder to detect broken model setup; the function should fail when error is present or response is absent.
Useful? React with 👍 / 👎.
| OLLAMA_HOST="http://127.0.0.1:11434" | ||
|
|
||
| PAPER_TITLE="Reality Built on a Finite Set of Geometric Instructions" | ||
| AUTHOR="Christopher Woodyard" |
There was a problem hiding this comment.
Replace hard-coded real-person identifier in demo script
The repository policy in AGENTS.md (section 9.1, Privacy/Sensitive Data and Neutral Wording) explicitly disallows committing real personal identifiers in code/docs/examples, but this line hard-codes a full personal name into runtime prompts. That creates avoidable privacy/compliance risk because the value is emitted in generated outputs and demo logs/screenshots.
Useful? React with 👍 / 👎.
R.A.I.N. Lab demo: Watch AI fight my own research paper
Summary
Describe this PR in 2-5 bullets:
mainfor all contributions):Label Snapshot (required)
risk: low|medium|high):size: XS|S|M|L|XL, auto-managed/read-only):core|agent|channel|config|cron|daemon|doctor|gateway|health|heartbeat|integration|memory|observability|onboard|provider|runtime|security|service|skillforge|skills|tool|tunnel|docs|dependencies|ci|tests|scripts|dev, comma-separated):<module>: <component>, for examplechannel: telegram,provider: kimi,tool: shell):trusted contributor|experienced contributor|principal contributor|distinguished contributor, auto-managed/read-only; author merged PRs >=5/10/20/50):Change Metadata
bug|feature|refactor|docs|security|chore):runtime|provider|channel|memory|security|ci|docs|multi):Linked Issue
Supersede Attribution (required when
Supersedes #is used)#<pr> by @<author>, one per line):Co-authored-bytrailers added for materially incorporated contributors? (Yes/No)No, explain why (for example: inspiration-only, no direct code/design carry-over):\n): (Pass/Fail)Validation Evidence (required)
Commands and result summary:
cargo fmt --all -- --check cargo clippy --all-targets -- -D warnings cargo testQuality Delta (required for medium/high risk changes)
Yes/No):Security Impact (required)
Yes/No)Yes/No)Yes/No)Yes/No)Yes, describe risk and mitigation:Privacy and Data Hygiene (required)
pass|needs-follow-up):Compatibility / Migration
Yes/No)Yes/No)Yes/No)i18n Follow-Through (required when docs or user-facing wording changes)
Yes/No)Yes, locale navigation parity updated inREADME*,docs/README*, anddocs/SUMMARY.mdfor supported locales (en,zh-CN,ja,ru,fr,vi)? (Yes/No)Yes, localized runtime-contract docs updated where equivalents exist (minimum forfr/vi:commands-reference,config-reference,troubleshooting)? (Yes/No/N.A.)Yes, Vietnamese canonical docs underdocs/i18n/vi/**synced and compatibility shims underdocs/*.vi.mdvalidated? (Yes/No/N.A.)No/N.A., link follow-up issue/PR and explain scope decision:Human Verification (required)
What was personally validated beyond CI:
Side Effects / Blast Radius (required)
Agent Collaboration Notes (recommended)
AGENTS.md+CONTRIBUTING.md):Rollback Plan (required)
Risks and Mitigations
List real risks in this PR (or write
None).