Skip to content

fix(foundations): reserve can fail even with +16 flag set #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novusnota wants to merge 8 commits into
base: main
Choose a base branch
from
+5 −6
Open

fix(foundations): reserve can fail even with +16 flag set #2016

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f15df16
Update reserve.mdx
memearchivarius Mar 24, 2026
4ad892d
Update internal.mdx
memearchivarius Mar 24, 2026
d9a542f
Update internal.mdx
memearchivarius Mar 24, 2026
66c8de4
fixed broken link
memearchivarius Mar 24, 2026
77b6a68
small edits; good work overall
novusnota Mar 24, 2026
6f4e35d
Merge branch 'main' into 2002-reserve-fix
novusnota Mar 24, 2026
882ad12
less words
novusnota Mar 24, 2026
3355bd1
Merge branch '2002-reserve-fix' of github.com:ton-org/docs into 2002-…
novusnota Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions foundations/actions/reserve.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,15 @@ Notation:
- `amount` – the amount of Toncoin passed to the `RAWRESERVE` instruction.
- `mode` – the integer mode passed to the `RAWRESERVE` instruction.
- `original_balance`:
- if after the storage phase, account's balance is less than the value of incoming message with bounce flag set to `false`, then `original_balance` is set to $0$;
- if after the storage phase, account's balance is less than the value of incoming message with bounce flag set to `false`, then `original_balance` is set to 0;
- otherwise, `original_balance` equals account's balance before the compute phase minus incoming message value.
- `remaining_balance` – account's balance before the reservation action.
- `reserve` – the final amount to be reserved.

The algorithm is as follows:

1. Check that `mode` has flag `ReserveBounceIfActionFail`:
- if so, then in case of any failure the action phase will be interrupted and the bounce phase will be initiated;
- if not, then in case of any failure the reservation action will be skipped.
- if so, then in case of any failure during reservation, the rest of the action phase will be skipped, and the bounce phase will be initiated afterward.
1. Set `reserve` to `amount`.
1. Check that `mode` has flag `ReserveAddOriginalBalance`:
1. If so, then check that `mode` has flag `ReserveInvertSign`:
Expand Down Expand Up @@ -86,4 +85,4 @@ The following errors can occur during the reservation flow:
- Some problems with unpacking the reserve action cell.
- A problem related to extra-currency.

If the action had flag `16`, then in case of any of the above errors a [bounce message](/foundations/messages/internal#bounces) is sent back to a sender.
If the action had flag `16`, i.e., `ReserveBounceIfActionFail`, then in case of any of the above errors the transaction enters [bounce phase](/foundations/phases#bounce-phase).
4 changes: 2 additions & 2 deletions foundations/messages/internal.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ A bounce message is used to inform the sender that handling of their message fai
- there is enough Toncoin to send it left from handling the failed message,
- and the message is bounceable,
- and when either
- a message throws an error from the [compute phase](/foundations/phases#compute-phase) during message processing and state was not committed by [`COMMIT`](/tvm/instructions#f80f-commit) TVM instruction,
- or a message throws an error in the [action phase](/foundations/phases#action-phase) and mode [`SendBounceIfActionFail`](/foundations/messages/modes) is used.
- a contract throws an error from the [compute phase](/foundations/phases#compute-phase) during message processing, and the state was not committed by [`COMMIT`](/tvm/instructions#f80f-commit) TVM instruction,
- or an action fails in the [action phase](/foundations/phases#action-phase) with the `+16` flag enabled, for example [`SendBounceIfActionFail`](/foundations/messages/modes) in case of message sends or [`ReserveBounceIfActionFail`](/foundations/actions/reserve#modes) in case of reservations.

### Default bounce

Expand Down
Loading