Skip to content

feat(foundations): normalized hash#1881

Open
memearchivarius wants to merge 14 commits intomainfrom
1877-normalized-hash
Open

feat(foundations): normalized hash#1881
memearchivarius wants to merge 14 commits intomainfrom
1877-normalized-hash

Conversation

@memearchivarius
Copy link
Collaborator

Closes #1877

This PR adds a new page about the normalized hash

@github-actions

This comment has been minimized.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates—I've left a couple of suggestions in foundations/messages to better align with the style guide; please apply the inline suggestions.

@novusnota novusnota changed the title feat: Normalized hash feat(foundations): normalized hash Mar 9, 2026
@github-actions

This comment has been minimized.

Copy link
Collaborator

@Shvandre Shvandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new article brings very little additional info and duplicates significant part of message-lookup article. Consider removing theoretical info from message-lookup or on the opposite hand, expand the message-lookup acticle using new info. The main issue is same as were in old docs, I can't clearly see how the information is divided into the articles

-Removed part of theory from message lookup
-Revised wording for other cases
-Removed misleading info
@github-actions
Copy link
Contributor

Thanks for the updates to ecosystem/ton-connect/message-lookup.mdx and foundations/messages/normalized-hash.mdx; I’ve left a couple of suggestions to align the tone, headings, and canonical reference language with the docs guidelines, so please apply the inline suggestions.


Per-comment submission: 1 posted, 3 failed.

Unposted inline comments (raw text):

  • ecosystem/ton-connect/message-lookup.mdx:L7-L11

    [HIGH] Danger Aside uses second-person “You should never …”

    The danger Aside body at the top of the page uses the sentence “You should never use external message tracking for payment processing purposes.” which directly addresses the reader in the second person. The style guide bans using “you/your” for readers and “we/I/our” for authors in documentation, including admonitions, to keep the tone neutral and impersonal. This phrasing violates the required voice and tone rules while conveying an important safety warning.

    <Aside  …(truncated)
    
    
  • ecosystem/ton-connect/message-lookup.mdx:L13-L15

    [HIGH] Non-descriptive “Introduction” section heading

    The H2 heading ## Introduction is a generic label that does not describe the specific topic of the section. The content underneath defines message lookup and its intended UX purpose, so a more specific heading is required for scanability and deep linking. The style guide calls for headings at the same nesting level to be unique and meaningful out of context, and discourages repeated or vague “Introduction” headings.

    Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

  • ecosystem/ton-connect/message-lookup.mdx:L167-L171

    [HIGH] Gerund-style task heading “Waiting for transaction confirmation”

    The H2 heading ## Waiting for transaction confirmation uses a gerund phrase that describes a state rather than a direct action. This section explains how to poll the blockchain using waitForTransaction, so it functions as a task/procedure. The style guide requires task and procedure headings to start with an imperative verb (for example, “Wait for transaction confirmation”) to make actions clearer in navigation and when scanning the table of contents.

    Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

@memearchivarius memearchivarius marked this pull request as draft March 24, 2026 09:21
@github-actions

This comment was marked as off-topic.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Messages > Normalized hash] Create a new page below external-in

3 participants