Bump nightly to nightly-2024-05-05#6538
Merged
Darksonn merged 23 commits intotokio-rs:masterfrom May 5, 2024
Merged
Conversation
Urgau
reviewed
May 5, 2024
Urgau
reviewed
May 5, 2024
Darksonn
commented
May 5, 2024
I couldn't reproduce locally
Fixes this error:
error[E0635]: unknown feature `stdsimd`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.4/src/lib.rs:99:42
|
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
| ^^^^^^^
As of 0.8.7, ahash no longer tries to use stdsimd on nightly
Darksonn
changed the title
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Darksonn
added
R-loom-time-driver
taiki-e
reviewed
May 5, 2024
Member
Author
|
Verified that everything including loom passes! |
github-actions
Bot
removed
R-loom-current-thread
taiki-e
approved these changes
May 5, 2024
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
May 7, 2024
This allows to find solutions to the false positives that were found in the ecosystem before turning it to `warn` by default again. Most projects hit by this seem to just disable the warning, which indicates that it isn't working as expected. CC rust-lang#124800 CC rust-lang#124804 CC rust-lang#124821 CC hyperium/hyper#3660 CC microsoft/windows-rs#3022 CC rust-bitcoin/rust-bitcoin#2748 CC tokio-rs/tokio#6538
This was referenced May 11, 2024
|
Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19), there is no longer any need for the kind of workarounds employed in this PR. Cargo has now gain the ability to declare
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }
Footnotes
|
Member
|
@Urgau |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence warnings from rust-lang/cargo#13571.
I tried to add a CI step that runs with the lint enabled as well. But it can't be enabled normally because
cargo buildneeds to just work for new contributors, and build scripts hurt performance too much.