pkgs/pkcs7: Fix python library installation#125
Draft
henrirosten wants to merge 1 commit intomainfrom
Draft
Conversation
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is an attempt to fix
pkcs7python library installation.This change fixes (or attempts to fix) the following problems:
disttoolspackage from https://github.com/jeppeter/disttools. The disttools isn't available in nixpkgs, nor is it packaged by the ci-test-automation flake. We would have to package it here, or break the dependency. The change done in this PR breaks the dependency, as it seems the package disttools is only needed for debugging. Therefore, this change simply removes the content from _ init_debug _.py that's between the tags##importdebugstartand##importdebugend.pkcs7library could be imported, but the library contents was empty. The reason was, the package name__init_debug__.pyis not valid. This PR renames the pkcs7__init_debug__.pyto__init__.pyto make the import work correctly. I doubt the earlier version of thepkcs7library - as imported in this flake - has ever worked. For more details, see this article.