Skip to content

Fix destroy button click navigating to show page on index #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
55728 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

Fix destroy button click navigating to show page on index #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/administrate/controllers/table_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default class extends Controller {
event.keyCode == keycodes.space ||
event.keyCode == keycodes.enter) {

if (event.target.href) {
if (event.target.closest("a[href], button, input[type='submit']")) {
return;
}

Expand Down
11 changes: 11 additions & 0 deletions spec/features/orders_index_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@
)
end

scenario "clicking destroy does not navigate to show page", js: true do
create(:order)

visit admin_orders_path
dismiss_confirm do
click_on t("administrate.actions.destroy")
end

expect(page).to have_current_path(admin_orders_path)
end

scenario "cannot delete because associated payment", js: true do
create(:payment, order: create(:order))

Expand Down