Fix ordering by custom primary key in has_many associations#3007
Open
goosys wants to merge 2 commits intothoughtbot:mainfrom
Open
Fix ordering by custom primary key in has_many associations#3007goosys wants to merge 2 commits intothoughtbot:mainfrom
goosys wants to merge 2 commits intothoughtbot:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this PR after the other PR is merged:
The diff is here.
I fixed
has_manyordering because group_by was using a fixed column:id.Also, when grouping is not possible, sorting is now skipped to avoid duplicate records.