Removed the link role from the index table#2844
Merged
Conversation
Each row of the collection table had a `role=link` attribute, which was removing the default "row" role. This caused screen readers to ignore all of the table's rows. Removing the attribute resolves this issue.
Contributor
Author
|
@pablobm I recommend merging this PR as sooner because it's make the table literally unusable to some people. Are you or @nickcharlton aware of a reason that removing this role would break anything? I don't really have any context on the history. |
pablobm
approved these changes
Jun 6, 2025
Collaborator
pablobm
left a comment
pablobm
left a comment
There was a problem hiding this comment.
Apologies, you are right. I mixed some stuff up in my head. I think we should merge then 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each row of the collection table had a
role=linkattribute, which was removing the default "row" role. This caused screen readers to ignore all of the table's rows. Removing the attribute resolves this issue.