Fix datetime formatting and update timezone default handling#2779
Merged
nickcharlton merged 1 commit intothoughtbot:mainfrom Feb 18, 2025
Merged
Fix datetime formatting and update timezone default handling#2779nickcharlton merged 1 commit intothoughtbot:mainfrom
nickcharlton merged 1 commit intothoughtbot:mainfrom
Conversation
This ensures consistency across public methods for `DateTime`, `Date`, and `Time` which all had slight differences. We remove the `default` option from `I18n.localize`, because an exception is thrown with `data.in_time_zone` when the `data` is `nil`, the `default` option is not meaningful. We don't need a fallback for the time zone, as with `Time.zone`, one is already defined. We also don't need to do a string conversion, as `in_time_zone` supports accepting a `Time.zone` object.
nickcharlton
force-pushed
the
2702-refactor-datetime-format
branch
from
8b52417 to
f2feb7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultoption fromI18n.localize:data.in_time_zonewhendataisnil, thedefaultoption was not meaningful..name:in_time_zonecan acceptTime.zoneobjects directly, so string conversion is also unnecessary.