Downgrade gRPC errors to warnings in remote execution logging#3511
Open
sean- wants to merge 1 commit intothought-machine:masterfrom
Open
Downgrade gRPC errors to warnings in remote execution logging#3511sean- wants to merge 1 commit intothought-machine:masterfrom
sean- wants to merge 1 commit intothought-machine:masterfrom
Conversation
Remote-side errors like CAS cache misses (NotFound) are logged as ERROR by the gRPC interceptor, but the client recovers gracefully by falling back to local execution. Downgrade these to WARNING to avoid noisy error output during normal builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote-side errors - like CAS cache misses (NotFound) - are logged as
ERRORby the gRPC interceptor, but the client recovers gracefully by falling back to local execution. Downgrade these toWARNINGto avoid noisy error output during normal builds.