Skip to content

[CRA-RXJS-SC] Fix redirect loop on login #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kodejuice wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CRA-RXJS-SC] Fix redirect loop on login #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cra-rxjs-styled-components/src/constants/url.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const SIGN_IN_BASE_URL = `${API_URL_BASE}/auth/signin`;
export const SIGN_IN_URL = (() => {
const url = new URL(SIGN_IN_BASE_URL);
url.searchParams.set('redirect_url', REDIRECT_URL);
console.log(url.toString());
return url.toString();
})();

Expand Down
9 changes: 7 additions & 2 deletions cra-rxjs-styled-components/src/hooks/auth/use-set-token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,20 @@ export function useSetToken() {
'Content-Type': 'application/json; charset=UTF-8',
}),
credentials: 'include',
selector: (response: Response) => response.json(),
selector: (response: Response) => {
const t = response.json();
console.log(t); // empty object on non-chromium browser (e.g Firefox)
return t;
},
})
.pipe(
tap(({ access_token }) => {
if (!access_token) {
throw new Error(`Error: could not retrieve token`);
}
}),
catchError(() => {
catchError((e) => {
alert(e);
navigate('/signin', { replace: true });
return EMPTY;
})
Expand Down