Added The Mad Noodle Folder, noodlepad_micro Keypad Definitions and udon13 Keypad Definitions #2131
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "name": "NoodlePad Micro", | ||
| "vendorId": "0x6A6C", | ||
| "productId": "0x0004", | ||
| "keycodes": ["qmk_lighting"], | ||
| "menus": ["qmk_rgblight"], | ||
| "customKeycodes": [ | ||
| { | ||
| "name": "RGB Layer Mode", | ||
| "title": "Toggle the RGB Layer Indicator Mode (Mode1: Blink White=0, Red=1, Green=2, Blue=3) / (Mode2: One LED lit white according to current layer)", | ||
| "shortName": "L_IND" | ||
| }, | ||
| { | ||
| "name": "Cycle Layers", | ||
| "title": "Cycle through the layers (Place on same key on all layers)", | ||
| "shortName": "L_CYC" | ||
| } | ||
| ], | ||
| "matrix": { | ||
| "rows": 3, | ||
| "cols": 3 | ||
| }, | ||
| "layouts": { | ||
| "keymap": [ | ||
| [ | ||
| {"c": "#777777" }, | ||
| "0,2\n\n\n\n\n\n\n\n\ne0", | ||
| {"x": 1}, | ||
| "0,0\n\n\n\n\n\n\n\n\ne1" | ||
| ], | ||
| [ | ||
| {"c": "#cccccc"}, | ||
| "1,2", | ||
| "1,1", | ||
| "1,0" | ||
| ], | ||
| [ | ||
| "2,2", | ||
| "2,1", | ||
| "2,0" | ||
| ] | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "name": "Udon:13", | ||
| "vendorId": "0x6A6C", | ||
| "productId": "0x0012", | ||
| "keycodes": ["qmk_lighting"], | ||
| "menus": ["qmk_rgblight"], | ||
| "customKeycodes": [ | ||
| { | ||
| "name": "Cycle Layers", | ||
| "title": "Cycle through the layers (Place on same key on all layers)", | ||
| "shortName": "L_CYC" | ||
| } | ||
| ], | ||
|
Comment on lines
+7
to
+13
Collaborator
There was a problem hiding this comment. I dont see the custom keycodes in QMK? |
||
| "matrix": { | ||
| "rows": 4, | ||
| "cols": 4 | ||
| }, | ||
| "layouts": { | ||
| "keymap": [ | ||
| [{"x":3,"c":"#777777"},"0,3\n\n\n\n\n\n\n\n\ne0"], | ||
| [{"y":0.25,"c":"#cccccc"},"1,0","1,1","1,2","1,3"], | ||
| ["2,0","2,1","2,2","2,3"], | ||
| ["3,0","3,1","3,2","3,3"] | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the custom keycodes in the QMK firmware?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh crap! I literally just committed those changes in today totally forgetting that they need to be in the QMK master as well.
I actually just made the PR today for those changes to QMK qmk/qmk_firmware#23003
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xelus22 I'd ideally like these changes in there, so should we wait until the QMK PR is merged?
Or should i revert that last commit for now? Or can we just push it through even though they arent in just yet.
The only reason I ask is because im in a bit of rush, since im trying to launch this new keypad ASAP and id like Easy via support on launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can either:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xelus22 I might wait, at least for the micro. Just because I think it'll make a difference for my customers.
If I do wait though, I don't really want to have to wait a long time for this to get merged. Is it ok if I @ you once the PR goes through so we can merge this ASAP? I'm super sorry, I know I'm probably being crazy annoying with this PR lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep all good. I usually get to these every weekend.