Skip to content

Fix Save Layout when showSaveFilePicker is unsupported #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishyv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Save Layout when showSaveFilePicker is unsupported #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 59 additions & 37 deletions src/components/panes/configure-panes/save-load.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,48 +110,70 @@ export const Pane: FC = () => {
}
};

const saveLayout = async () => {
const {name, vendorProductId} = selectedDefinition;
const suggestedName =
name.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase() + '.layout.json';
try {
const handle = await window.showSaveFilePicker({
suggestedName,
});
const encoderValues = await getEncoderValues();
const saveFile: ViaSaveFile = {
name,
vendorProductId,
macros: [...expressions],
layers: rawLayers.map(
(layer: {keymap: number[]}) =>
layer.keymap.map(
(keyByte: number) =>
getCodeForByte(keyByte, basicKeyToByte, byteToKey) || '',
), // TODO: should empty string be empty keycode instead?
),
encoders: encoderValues,
};

const content = stringify(saveFile);
const blob = new Blob([content], {type: 'application/json'});
const writable = await handle.createWritable();
await writable.write(blob);
await writable.close();
} catch (err) {
console.log('User cancelled save file request');
// `showSaveFilePicker` (File System Access API) isn't supported everywhere and can
// fail without showing a prompt in some contexts. Prefer it when available, but
// fall back to a standard Blob download so "Save" always works.
const saveBlobAsFile = async (blob: Blob, suggestedName: string) => {
const showSaveFilePicker = window.showSaveFilePicker;
if (typeof showSaveFilePicker === 'function') {
try {
const handle = await showSaveFilePicker({
suggestedName,
types: [
{
description: 'JSON',
accept: {'application/json': ['.json']},
},
],
});
const writable = await handle.createWritable();
await writable.write(blob);
await writable.close();
return;
} catch (err) {
if ((err as any)?.name === 'AbortError') {
return;
}
console.error(err);
}
}

/*
const url = URL.createObjectURL(blob);
try {
const link = document.createElement('a');
link.href = url;
link.download = suggestedName;
link.rel = 'noopener';
document.body.appendChild(link);
link.click();
link.remove();
} finally {
setTimeout(() => URL.revokeObjectURL(url), 0);
}
};

const link = document.createElement('a');
link.href = url;
link.download = defaultFilename;
const saveLayout = async () => {
const {name, vendorProductId} = selectedDefinition;
const suggestedName =
name.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase() + '.layout.json';
const encoderValues = await getEncoderValues();
const saveFile: ViaSaveFile = {
name,
vendorProductId,
macros: [...expressions],
layers: rawLayers.map(
(layer: {keymap: number[]}) =>
layer.keymap.map(
(keyByte: number) =>
getCodeForByte(keyByte, basicKeyToByte, byteToKey) || '',
), // TODO: should empty string be empty keycode instead?
),
encoders: encoderValues,
};

link.click();
URL.revokeObjectURL(url);
*/
const content = stringify(saveFile);
const blob = new Blob([content], {type: 'application/json'});
await saveBlobAsFile(blob, suggestedName);
};

const loadLayout = ([file]: Blob[]) => {
Expand Down