fix: getQueriesForElement types#1354
Open
rodgobbi wants to merge 1 commit intotesting-library:mainfrom
Open
Conversation
timdeschryver
approved these changes
Apr 3, 2025
Member
timdeschryver
left a comment
There was a problem hiding this comment.
This change looks good to me.
The failing build is something we'll have to look into, I will create an issue to look into this.
Author
Thanks for checking @timdeschryver 👍 I noticed the CI failing and checked if it happened to other PRs and indeed it looked like some issue in every PR. Lemme know when it gets fixed, I can merge with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix
getQueriesForElementtype.Why:
Type definition for
getQueriesForElementdoesn't match the JS implementation.How:
Add
initialValuethird parameter to the function signature.Checklist:
docs site N/A