feat(roleHelpers): compute tree implicit arialevel#1088
feat(roleHelpers): compute tree implicit arialevel#1088MatanBobi wants to merge 2 commits intotesting-library:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd129b6:
|
|
Should I review this considering it's in draft and you said it's not ready yet? |
Worth considering REF:
Update: on re-read of the implementation, I think this might be all ok (and my concerns r.e. nested already mitigated by the implementation), apologies should read properly first and comment later. Comment r.e. other roles stands, and suspect would be good to add the more complex nesting examples as test cases. |
What: Adding the option to implicitly get the
aria-levelof atreeitemWhy: Resolves #980
How: At the moment, I'm using the naive approach and climb up the tree until I reach a node with explicit role
tree.This isn't ready yet, it's just a draft to see if this approach looks good.
Checklist:
docs site