Skip to content

SW-8002 Fix model disappearing when rerendering #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ice1080 merged 1 commit into from
Jan 29, 2026
Merged

SW-8002 Fix model disappearing when rerendering #5144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../ObservationsRouterV2/SingleView/PlantMonitoring/MonitoringPlot/VirtualMonitoringPlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ const VirtualMonitoringPlot = ({ observationId, fileId }: VirtualMonitoringPlotP
<Script script={XrNavigation} />
</Entity>

<SplatModel splatSrc={splatSrc} rotation={[-180, 0, 0]} />
{/* When a rerender occurs (such as changing showAnnotations), the splat model disappears (https://github.com/playcanvas/react/pull/298 and https://github.com/playcanvas/react/issues/302) */}
{/* The key includes showAnnotations the PR is merged and we're on a version that includes it */}
<SplatModel key={`splat-${showAnnotations}`} splatSrc={splatSrc} rotation={[-180, 0, 0]} />

<Script
script={TfAnnotationManager}
Expand Down
Loading