Open
Conversation
|
@shanginn is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This MR adds a repo-canonical SDK client for Temporal operator APIs and exposes namespace deletion through the PHP SDK.
The main change is a new
OperatorClient/OperatorClientInterfacegenerated from Temporal'sOperatorServiceClient, so SDK users can call operator RPCs, includingDeleteNamespace, without reimplementing the shared gRPC client layer in user code.To support that cleanly, the shared gRPC client plumbing was generalized so workflow and operator clients use the same SDK behavior for connection handling, metadata,
interceptors, retries, and call context.
While validating the change, I also fixed the test and harness issues required to keep the branch green repo-wide:
Why?
Issue #400 is about deleting namespaces through the PHP SDK in the same way other SDK-supported APIs are accessed.
The generated Temporal operator stub already existed, but it was not exposed through the SDK’s own client abstraction. That meant users had to bypass the SDK conventions or
duplicate internal client behavior just to use
DeleteNamespace.This MR makes operator APIs first-class in the SDK, keeps the implementation aligned with the existing client architecture, and ensures the full repository still passes its checks
after the change.
Checklist
Closes [Feature Request] Expose OperatorServiceClient #400
How was this tested:
composer validate --strictvendor/bin/php-cs-fixer fix --dry-run -v --diff --show-progress dots --sequential --allow-unsupported-php-version=yesvendor/bin/psalm --no-cache --threads=1composer test:unitCOMPOSER_PROCESS_TIMEOUT=0 TEMPORAL_ADDRESS=127.0.0.1:17234 composer test:funcCOMPOSER_PROCESS_TIMEOUT=0 TEMPORAL_ADDRESS=127.0.0.1:17233 composer test:accept-fastCOMPOSER_PROCESS_TIMEOUT=0 TEMPORAL_ADDRESS=127.0.0.1:17233 composer test:accept-slowCOMPOSER_PROCESS_TIMEOUT=0 TEMPORAL_ADDRESS=127.0.0.1:17233 composer test:acceptcomposer test:archOperatorClientexample that includes namespace deletion