fix: testing environment config file ignored and needlessly wait for timeout#735
fix: testing environment config file ignored and needlessly wait for timeout#735mtorromeo wants to merge 3 commits intotemporalio:masterfrom
Conversation
|
@mtorromeo is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
54ebcb7 to
f260474
Compare
|
I forgot to add that there was a third fix in the PR. If startRoadrunner is passed a custom The proposed solution is to use I just separated the commit for easier review. |
|
I would also like to point out that in my opinion the classes in this SDK seem to be declared as final a bit too often, and while sometimes it is indeed a good call, other times I don't see any reason to do so.
|
What was changed
Changed
Temporal\Testing\Environment::startRoadRunnerto actually use the$configFileparameter and to not wait for timeout if the process is not running.Why?
In
Temporal\Testing\EnvironmentthestartRoadRunnerhas a$configFileparameter, which is also passed through thestartmethod's$roadRunnerConfigFileparameter but that is completely ignored.In
startRoadRunnerif the executed process crashes/exists before$commandTimeouttriggers (which is 10 seconds by default but could also be much longer) then the function will wait needlessly for the timeout while it could return right away.Checklist
Confirmed by testing it on my own project, also with a misconfigured command that does not start correctly.