Skip to content

fix(deps): exclude @types/* packages from component peer dependencies #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidfirst wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(deps): exclude @types/* packages from component peer dependencies #10186

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ea9786
fix(deps): exclude @types/* packages from component peer dependencies
davidfirst Feb 5, 2026
c4637a1
refactor(deps): extract helper methods to reduce cognitive complexity
davidfirst Feb 5, 2026
a62dafc
Merge branch 'master' into fix/exclude-types-from-component-peers
davidfirst Feb 5, 2026
7cb0f29
Merge branch 'master' into fix/exclude-types-from-component-peers
davidfirst Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scopes/dependencies/dependencies/dependencies-loader/apply-overrides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,16 @@ export class ApplyOverrides {
if (field === 'peerDependencies') {
delete this.allPackagesDependencies.devPackageDependencies[pkgName];
delete this.allPackagesDependencies.packageDependencies[pkgName];
// @types/* packages should not be added to components at all when in env peers.
// When a component is installed in a workspace, its env is installed as well.
// Packages listed as peers in env.jsonc become runtime dependencies of the env itself,
// so they're always installed alongside the env. Since @types/* packages are only needed
// for TypeScript compilation (which the env handles), there's no need for components
// to have them in their own dependencies.
if (pkgName.startsWith('@types/')) {
delete this.allPackagesDependencies.peerPackageDependencies[pkgName];
Comment thread
davidfirst marked this conversation as resolved.
Outdated
return;
}
if (existsInCompsDeps) {
this.allDependencies.dependencies = this.allDependencies.dependencies.filter(
(dep) => dep.packageName !== pkgName
Expand Down
Loading