Skip to content

Improve tap command response handling with error reporting#18

Open
pkkid wants to merge 1 commit intotchebb:mainfrom
pkkid:17-better-responses
Open

Improve tap command response handling with error reporting#18
pkkid wants to merge 1 commit intotchebb:mainfrom
pkkid:17-better-responses

Conversation

@pkkid
Copy link
Copy Markdown

@pkkid pkkid commented Jan 26, 2026

This solves issue #17.

Before:

  • Simply printed the debug output of the result: println!("{result:?}")

After:

  • Properly handles success and error cases separately
  • For successful responses:
    • Displays "(empty response)" when the response is empty
    • Displays the actual response string cleanly (without debug formatting)
  • For errors: displays them with debug formatting prefixed by "Error:"

This makes the interactive TAP command interface more user-friendly by showing clean output instead of Rust's debug representation for successful responses.

@tchebb
Copy link
Copy Markdown
Owner

tchebb commented Jan 29, 2026

Hi Michael! Thanks for all your contributions over the past few days. I know I've been neglecting this project, and I want to get back to it. Unfortunately, I'm currently in the middle of an international move and don't have time to review anything in the immediate future. I should have time in mid-February, though.

@pkkid
Copy link
Copy Markdown
Author

pkkid commented Feb 3, 2026

No worries. It's speaker software, we shouldn't need to feel rushed. :D
I hope your move goes well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants