Skip to content

Indicate rule for WEB_FEATURES.yml lint errors #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eemeli wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Indicate rule for WEB_FEATURES.yml lint errors #4993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/web-features/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,13 @@ def main(web_features_filename, manifest_filename):
path_specs = feature['files']
tag_specs = feature.get('tags', [])

manifest['data'][name] = [*filter(
lambda candidate: match(candidate, tag_specs),
get_filenames_from_path_specs(path_specs)
)]
try:
manifest['data'][name] = [*filter(
lambda candidate: match(candidate, tag_specs),
get_filenames_from_path_specs(path_specs)
)]
except AssertionError as error:
raise ValueError(f"Invalid rule for {name}") from error

if manifest_filename:
with open(manifest_filename, 'w') as manifest_handle:
Expand Down
Loading