Conversation
ioannad
force-pushed
the
temporal-function-acceptable-undefined-options
branch
from
e99081e to
97f9b46
Compare
ptomato
approved these changes
Mar 11, 2026
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks! Couple of comments, otherwise looks good. Feel free to merge when they are addressed.
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/direction-undefined.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/PlainYearMonth/prototype/with/copy-properties-not-undefined.js
Outdated
Show resolved
Hide resolved
ljharb
approved these changes
Mar 11, 2026
ptomato
reviewed
Mar 17, 2026
test/built-ins/Temporal/PlainYearMonth/prototype/with/copy-properties-not-undefined.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
ptomato
force-pushed
the
temporal-function-acceptable-undefined-options
branch
from
35d2c2d to
42f4151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.