Open
Conversation
sssciel
force-pushed
the
g.rybakov/tntp-7385-add-gs-data-types-cluster
branch
3 times, most recently
from
9cd7cf0 to
d653189
Compare
sssciel
force-pushed
the
g.rybakov/tntp-7385-add-gs-data-types-cluster
branch
2 times, most recently
from
60785ee to
96a0dd5
Compare
| errDataMissing = errors.New("data does not exist") | ||
| errWrongRevision = errors.New("wrong revision") | ||
|
|
||
| errManyResponses = errors.New("too many responses") |
Contributor
There was a problem hiding this comment.
Looks unused in the repository.
ap@ap:work/git/tt (g.rybakov/tntp-7385-add-gs-data-types-cluster) $ grep -rne 'errManyResponses' . --include=*.go
./lib/cluster/errors.go:35: errManyResponses = errors.New("too many responses")
ap@ap:work/git/tt (g.rybakov/tntp-7385-add-gs-data-types-cluster) $
Comment on lines
+277
to
+278
|
|
||
| func NewStorage(storage gstorage.Storage, prefix string, timeout time.Duration, key string, storageType string) RawStorage { |
Contributor
There was a problem hiding this comment.
There should be a comment, I think.
lib/cluster has its own implementations for connecting to configuration repositories. Work has begun on the transition to a single go-storage package. Closes TNTP-7385
sssciel
force-pushed
the
g.rybakov/tntp-7385-add-gs-data-types-cluster
branch
from
96a0dd5 to
b192606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/cluster has its own implementations for connecting to configuration
repositories. Work has begun on the transition
to a single go-storage package.
Closes TNTP-7385