Skip to content

Fix invalid "require" in benchmark.yml#3039

Open
OpenByteDev wants to merge 1 commit intosubquery:mainfrom
OpenByteDev:patch-1
Open

Fix invalid "require" in benchmark.yml#3039
OpenByteDev wants to merge 1 commit intosubquery:mainfrom
OpenByteDev:patch-1

Conversation

@OpenByteDev
Copy link
Copy Markdown

@OpenByteDev OpenByteDev commented Apr 21, 2026

Description

Replaced invalid workflow_dispatch.inputs.*.require with required, see also https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax?utm_source=chatgpt.com#onworkflow_dispatchinputsinput_idrequired.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • [x Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions benchmark workflow input configuration schema for improved parameter validation compliance.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5514953-2031-468a-8522-a5392b3988b7

📥 Commits

Reviewing files that changed from the base of the PR and between 51e2a2c and f7158ce.

📒 Files selected for processing (1)
  • .github/workflows/benchmark.yml

📝 Walkthrough

Walkthrough

GitHub Actions workflow configuration corrected by changing the require key to required across all workflow_dispatch input parameters in the benchmark workflow file. This updates the schema to use the correct YAML key name for GitHub Actions input validation.

Changes

Cohort / File(s) Summary
Benchmark Workflow Configuration
.github/workflows/benchmark.yml
Corrected workflow_dispatch input metadata schema by replacing require with required key across all 10 input parameters (cpus, memory, benchmark-time, indexerVersion, deployment, network-endpoint, disableHistorical, batch-size, workers, others).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A workflow once confused by require,
Now shines with required so bright!
GitHub Actions reads with glee,
The syntax fixed for all to see,
Configuration perfected right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing an invalid 'require' key to the correct 'required' key in the benchmark.yml workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant