-
Notifications
You must be signed in to change notification settings - Fork 181
docs: fix typos, grammar, and improve contributing docs #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dark-Brain07
wants to merge
9
commits into
stx-labs:main
Choose a base branch
from
Dark-Brain07:feature/docs-and-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
484e918
fix: typo 'branc' to 'branch' in README
Dark-Brain07 432c4e6
fix: correct SDK wrapper path in README
Dark-Brain07 ad1c532
fix: update broken Code of Conduct link in README
Dark-Brain07 824aab5
docs: complete contribution prerequisites in CONTRIBUTING.md
Dark-Brain07 956aba6
docs: add checklist items to PR template
Dark-Brain07 fa44ced
fix: grammar 'an other' to 'another' in README
Dark-Brain07 83bc227
fix: grammar 'all PR' to 'all PRs' in README
Dark-Brain07 ad72920
docs: add explanatory comments to codecov.yml
Dark-Brain07 08993e7
docs: add Windows/Linux installation tip in README
Dark-Brain07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,4 +15,6 @@ | |
| ### Checklist | ||
|
|
||
| - [ ] Tests added in this PR (if applicable) | ||
|
|
||
| - [ ] Code builds without errors (`cargo build`) | ||
| - [ ] Code formatted with `cargo fmt-stacks` | ||
|
Comment on lines
+18
to
+19
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The CI while check that, no need for additional checkboxes |
||
| - [ ] Documentation updated (if applicable) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,9 @@ brew install clarinet | |
| ``` | ||
|
|
||
| > To check out more installation methods, click | ||
| > [here](https://docs.hiro.so/stacks/clarinet#installation) | ||
| > [here](https://docs.hiro.so/stacks/clarinet#installation). | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docs link updated (see conflicts I guess) |
||
|
|
||
| > **Tip:** If you're on Windows or Linux, check the installation docs for platform-specific instructions. | ||
|
|
||
| ```bash | ||
| # Create a new project | ||
|
|
@@ -97,10 +99,10 @@ of Rust and Node.js (LTS) tooling. | |
| This repo follows the [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/#summary) | ||
| specification when writing commit messages. | ||
|
|
||
| **Note:** These conventions are helpful for any commit message, but all PR end up being merged with | ||
| "squash and merge", giving an other chance to refine the commit messages. | ||
| **Note:** These conventions are helpful for any commit message, but all PRs end up being merged with | ||
| "squash and merge", giving another chance to refine the commit messages. | ||
|
|
||
| To start contributing, fork this repo and open a new branc: | ||
| To start contributing, fork this repo and open a new branch: | ||
|
|
||
| 1. Fork this repo and clone the fork locally. | ||
| 1. Create a new branch | ||
|
|
@@ -133,7 +135,7 @@ For VSCode users, we recommend opening the following workspace | |
| Wasm target. | ||
|
|
||
| The SDK is divided between the Rust lib compiled to Wasm `./components/clarinet-sdk-wasm` and a TS | ||
| wrapper around it: `./components/clarinet-sdk-wasm`. | ||
| wrapper around it: `./components/clarinet-sdk`. | ||
|
|
||
| 1. Compile the Wasm package with `npm run build:sdk-wasm` | ||
| 1. Compile the SDK with `npm run build:sdk` | ||
|
|
@@ -143,7 +145,7 @@ Learn more in the [SDK Readme.md](./components/clarinet-sdk/README.md). | |
|
|
||
| ### Code of Conduct | ||
|
|
||
| Please read our [Code of conduct](../../../.github/blob/main/CODE_OF_CONDUCT.md) since we expect | ||
| Please read our [Code of Conduct](.github/CONTRIBUTING.md) since we expect | ||
| project participants to adhere to it. | ||
|
|
||
| ## Community | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that's useful as it, but I like the idea of removing this old "wip".
So that we don't have to update the versions in the future, I'd recommend setting:
Remove git and vscode, at this point, we expect contributors to know what they are doing.
And we could move the whole README prerequisites section here