Replace Android-only isDigitsOnly() with Kotlin stdlib for iOS compatibility#6794
Open
michaelabon wants to merge 1 commit intostreetcomplete:masterfrom
Open
Replace Android-only isDigitsOnly() with Kotlin stdlib for iOS compatibility#6794michaelabon wants to merge 1 commit intostreetcomplete:masterfrom
michaelabon wants to merge 1 commit intostreetcomplete:masterfrom
Conversation
…ibility
BlockStepperButton.kt used `androidx.core.text.isDigitsOnly`, which is
unavailable in commonMain when compiling for iOS. Replace with the
equivalent `value.all { it.isDigit() }` from the Kotlin stdlib.
Part of the Kotlin Multiplatform / iOS port effort (streetcomplete#5421).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockStepperButton.ktincommonMainimportsandroidx.core.text.isDigitsOnly, which is an Android-only extension and unavailable when compiling for iOS targets.Replace it with the equivalent
value.all { it.isDigit() }from the Kotlin stdlib, which works on all platforms. Behaviour is identical: both check that every character in the string is a digit.Part of the iOS port effort (#5421).
I'm excited by the idea of an iOS port for StreetComplete, so that I can stop tethering my old Android tablet to my phone while I'm out on walks. I figured I could get off my butt and start helping a bit. This problem (and the next one) seem to be small iOS compat issues that would be good-first-fixes for me.