Skip to content

Batch ack exchange route messages#617

Open
gaoran10 wants to merge 1 commit intostreamnative:masterfrom
gaoran10:batch-ack-for-exchange-route
Open

Batch ack exchange route messages#617
gaoran10 wants to merge 1 commit intostreamnative:masterfrom
gaoran10:batch-ack-for-exchange-route

Conversation

@gaoran10
Copy link
Copy Markdown
Collaborator

Motivation

After the exchange messages route finish, we need to ack the message, this will cost a lot of CPU resources, we can ack messages in batch.

Modifications

Use a single executor to batch ack exchange messages.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@gaoran10 gaoran10 requested review from a team and codelipenghui as code owners July 24, 2022 06:08
@github-actions github-actions Bot added the no-need-doc This pr does not need any document label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document release/2.10.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant