This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Prototype for typed_tag. Solve#277
Draft
elijahbenizzy wants to merge 2 commits into
Draft
Conversation
#276 This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#276
This is a little rough -- we need more testing. But it should work. Followed the spec at it was fairly clean -- using typed dicts, and validating on decoration. Also restricting to only primitives -- we can change it later but I want to keep things a lot simpler for now.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist