Skip to content

update stan to be compatible with Eigen 5.0.1 #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveBronder merged 2 commits into from
Feb 11, 2026
+7 −7
Merged

update stan to be compatible with Eigen 5.0.1 #3371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bbd44a
update stan to be compatible with Eigen 5.0.1
SteveBronder Feb 6, 2026
0f80d7d
update to use Eigen::indexing instead of Eigen::placeholders
SteveBronder Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/stan/model/indexing/rvalue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ inline auto rvalue(EigMat&& x, const char* name, MultiIndex&& idx) {
[](auto&& x_ref, auto&& idx_inner) {
using vec_map = Eigen::Map<const Eigen::Array<int, -1, 1>>;
return x_ref((vec_map(idx_inner.ns_.data(), idx_inner.ns_.size()) - 1),
Eigen::all);
Eigen::placeholders::all);
},
stan::math::to_ref(std::forward<EigMat>(x)),
std::forward<MultiIndex>(idx));
Expand Down Expand Up @@ -591,7 +591,7 @@ inline auto rvalue(EigMat&& x, const char* name, Idx&& row_idx,
[name](auto&& x_ref, auto&& row_idx_inner, auto&& col_idx_inner) {
using vec_map = Eigen::Map<const Eigen::Array<int, -1, 1>>;
return rvalue(
x_ref(Eigen::all,
x_ref(Eigen::placeholders::all,
(vec_map(col_idx_inner.ns_.data(), col_idx_inner.ns_.size())
- 1)),
name, std::forward<decltype(row_idx_inner)>(row_idx_inner));
Expand Down
4 changes: 2 additions & 2 deletions src/test/unit/services/pathfinder/eight_schools_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ TEST_F(ServicesPathfinderEightSchools, multi) {
EXPECT_GE(param_vals.col(2)(i), 0);
EXPECT_LE(param_vals.col(2)(i), num_paths);
}
auto param_tmp = param_vals(Eigen::all, param_indices);
auto param_tmp = param_vals(Eigen::placeholders::all, param_indices);
auto mean_sd_pair = stan::test::get_mean_sd(param_tmp);
auto&& mean_vals = mean_sd_pair.first;
auto&& sd_vals = mean_sd_pair.second;
Expand Down Expand Up @@ -448,7 +448,7 @@ TEST_F(ServicesPathfinderEightSchools, single) {
for (auto&& x_i : param_vals.col(2)) {
EXPECT_EQ(x_i, stride_id);
}
auto param_tmp = param_vals(Eigen::all, param_indices);
auto param_tmp = param_vals(Eigen::placeholders::all, param_indices);
auto mean_sd_pair = stan::test::get_mean_sd(param_tmp);
auto&& mean_vals = mean_sd_pair.first;
auto&& sd_vals = mean_sd_pair.second;
Expand Down
6 changes: 3 additions & 3 deletions src/test/unit/services/pathfinder/normal_glm_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ TEST_F(ServicesPathfinderGLM, single) {
EXPECT_EQ(x_i, stride_id);
}

auto param_tmp = param_vals(Eigen::all, param_indices);
auto param_tmp = param_vals(Eigen::placeholders::all, param_indices);
auto mean_sd_pair = stan::test::get_mean_sd(param_tmp);
auto&& mean_vals = mean_sd_pair.first;
auto&& sd_vals = mean_sd_pair.second;
Expand Down Expand Up @@ -240,7 +240,7 @@ TEST_F(ServicesPathfinderGLM, multi_null_unique) {
EXPECT_GE(param_vals.col(2)(i), 0);
EXPECT_LE(param_vals.col(2)(i), num_paths);
}
auto param_tmp = param_vals(Eigen::all, param_indices);
auto param_tmp = param_vals(Eigen::placeholders::all, param_indices);
auto mean_sd_pair = stan::test::get_mean_sd(param_tmp);
auto&& mean_vals = mean_sd_pair.first;
auto&& sd_vals = mean_sd_pair.second;
Expand Down Expand Up @@ -318,7 +318,7 @@ TEST_F(ServicesPathfinderGLM, multi) {
EXPECT_GE(param_vals.col(2)(i), 0);
EXPECT_LE(param_vals.col(2)(i), num_paths);
}
auto param_tmp = param_vals(Eigen::all, param_indices);
auto param_tmp = param_vals(Eigen::placeholders::all, param_indices);
auto mean_sd_pair = stan::test::get_mean_sd(param_tmp);
auto&& mean_vals = mean_sd_pair.first;
auto&& sd_vals = mean_sd_pair.second;
Expand Down