Skip to content

Support private record serialization #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
migmacdev wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −1
Open

Support private record serialization #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9188b
Support private record serialization
migmacdev Mar 3, 2026
3de044b
Update to privateLookupIn for private access
migmacdev Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions moshi/records-tests/src/test/java/com/squareup/moshi/records/RecordsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,5 +290,16 @@ public void nullObjectIsNull() throws IOException {
assertThat(adapter.toJson(value)).isEqualTo("{\"i\":5}");
}

@Test
public void privateRecordSerializesCorrectly() throws IOException {
var adapter = moshi.adapter(PrivateRecord.class);
String json = "{\"id\":\"1\",\"value\":123}";
PrivateRecord privateRecord = new PrivateRecord("1", 123);
assertThat(adapter.fromJson(json)).isEqualTo(privateRecord);
assertThat(adapter.toJson(privateRecord)).isEqualTo(json);
}

private record PrivateRecord(String id, int value) {}

public record AbsentValues(String s, int i) {}
}
7 changes: 6 additions & 1 deletion moshi/src/main/java16/com/squareup/moshi/internal/RecordJsonAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,12 @@ internal class RecordJsonAdapter<T>(

val components = rawType.recordComponents
val bindings = LinkedHashMap<String, ComponentBinding<Any?>>()
val lookup = MethodHandles.lookup()
var lookup = MethodHandles.lookup()
try {
lookup = MethodHandles.privateLookupIn(rawType, lookup)
} catch (_: IllegalAccessException) {
// fallback to standard lookup
}
val componentRawTypes =
Array<Class<*>>(components.size) { i ->
val component = components[i]
Expand Down